Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): remove no longer used postcss-present-env from dependencies #4506

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Mar 24, 2021

Motivation

postcss-present-env is no longer used after changes done in #4355, this pr updates documentation and removes this package from dependencies

this change has been extracted from #4404

https://github.com/facebook/docusaurus/pull/4355/files#diff-0c33a9be9b9aca4b4536266cc9c2b8db8131f03a7bc2cec8c5ccf27ea63cbc82L76-R76

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

#4355, #4404

@armano2 armano2 requested review from lex111 and slorber as code owners March 24, 2021 06:00
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 24, 2021
@netlify
Copy link

netlify bot commented Mar 24, 2021

@armano2 armano2 force-pushed the fix/postcss-present-env branch from 5176da1 to 7185fae Compare March 24, 2021 06:07
@netlify
Copy link

netlify bot commented Mar 24, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 5176da1

https://deploy-preview-4506--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4506--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Mar 24, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 7185fae

https://deploy-preview-4506--docusaurus-2.netlify.app

plugins: [
require('postcss-preset-env')({
autoprefixer: {
flexbox: 'no-2009',
},
stage: 4,
}),
],
plugins: [require('autoprefixer')],
Copy link
Contributor Author

@armano2 armano2 Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postcssOptions: {
// Necessary for external CSS imports to work
// https://github.com/facebook/create-react-app/issues/2677
ident: 'postcss',
plugins: [
// eslint-disable-next-line @typescript-eslint/no-var-requires, global-require
require('autoprefixer'),
],
},

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Mar 29, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 29, 2021

thanks 👍

@slorber slorber merged commit 5534aff into facebook:master Mar 29, 2021
@armano2 armano2 deleted the fix/postcss-present-env branch November 3, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants